Repository navigation
CRASM - 4247 ME report uploads and scoped S3 retention - #1710
Merged
Merged
Conversation
cduhn17
requested review from
ameliav,
hawkishpolicy,
jayjaybunce,
nickviola,
rapidray12 and
schmelz21
as code owners
November 6, 2026 17:45
rapidray12
approved these changes
Nov 9, 2026
rapidray12
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed in a group meetng
jayjaybunce
approved these changes
Nov 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
Add upload access for the two supplied ME instance roles to five report prefixes in cisa-was-reports:
cybex_scorecard/
cyhy_ad-hoc_notifications/
cyhy_vs_reports/
https_reports/
trustymail_reports/
Require HTTPS and SSE-KMS encryption using the approved customer managed key.
Enable 14-day expiration for these prefixes, with noncurrent-version, incomplete-upload, and delete-marker cleanup.
Preserve the existing HTTPS-only bucket policy. Leave ownership, ACLs, default encryption, and was_reports/ and capacity/ behavior unchanged.
Keep analyst download access independent of ME uploads.
Validation: Terraform 1.0.7 formatting and validation, 15 local mocked checks, and all applicable pre-commit checks passed. Test tooling remains outside the repository.
💭 Motivation and context
VS report requests currently depend on TechOps retrieving copies, which can delay customer inquiries and responses. This change establishes ME report uploads and the two-week temporary storage described in the ticket and supporting email while preserving existing WAS operations.
✅ Pre-approval checklist
AI was used to generate code in this PR (either fully or in part).
I attest that I understand the AI-generated code and its functionality.
I am comfortable answering questions about the implementation of the AI-generated code.
✅ Pre-merge checklist
✅ Post-merge checklist